Skip to content

[CI] pre-commit/aws pointed back to old image. #14074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 4 commits into from
Jun 6, 2024
Merged

[CI] pre-commit/aws pointed back to old image. #14074

steffenlarsen merged 4 commits into from
Jun 6, 2024

Conversation

@JackAKirk
Copy link
Contributor

@JackAKirk JackAKirk commented Jun 6, 2024

temp fix for problems from cuda 12.5 uplift that were caused by #14049. Should fix #14071

@JackAKirk
pre-commit/aws pointed back to old image.
54d68a1 
temp fix for problems from cuda 12.5 uplift.

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk requested a review from a team as a code owner June 6, 2024 10:34
@JackAKirk JackAKirk mentioned this pull request Jun 6, 2024
Closed
steffenlarsen
steffenlarsen approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🚀

This was referenced Jun 6, 2024
Merged
Merged
@JackAKirk JackAKirk marked this pull request as draft June 6, 2024 10:51
JackAKirk added 3 commits June 6, 2024 11:58
@JackAKirk
Point to commit where docker rebuilt.
b37d05a 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Correct the last commit.
9b91f91 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk
Try another commit.
7c4929a 
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@JackAKirk JackAKirk marked this pull request as ready for review June 6, 2024 11:32
@JackAKirk
Copy link
Contributor Author

JackAKirk commented Jun 6, 2024 •
edited
Loading

It seems that #13771 was the last commit to trigger a docker build, so I've pointed to that commit.
Note there are still the same failures in this PR as in others, since this PR needs to be merged before the docker image used in the testing is actually updated to reflect the change from this PR.

@JackAKirk
Copy link
Contributor Author

JackAKirk commented Jun 6, 2024

@intel/llvm-gatekeepers this can now be merged to fix the CI.

@steffenlarsen steffenlarsen merged commit f4829ab into intel:sycl Jun 6, 2024
@aelovikov-intel aelovikov-intel mentioned this pull request Jun 6, 2024
Merged
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
@JackAKirk @ianayl
[CI] pre-commit/aws pointed back to old image. (intel#14074)
b0572cb 
temp fix for problems from cuda 12.5 uplift that were caused by
intel#14049. Should fix
intel#14071

---------

Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
@uditagarwal97 uditagarwal97 mentioned this pull request Sep 10, 2024
Merged
aelovikov-intel pushed a commit that referenced this pull request Sep 10, 2024
@uditagarwal97
Revert '[CI] pre-commit/aws pointed back to old image' (#15348)
40e2f62 
Reverts #14074. This will allow us to
use latest docker images.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E2E on AWS CUDA Not finding devices

2 participants

@JackAKirk @steffenlarsen