[SYCL][COMPAT] Migrate currently unsupported memcpy_parameter overloads #14039
Conversation
Signed-off-by: Joe Todd <joe.todd@codeplay.com>
Signed-off-by: Joe Todd <joe.todd@codeplay.com>
There is actually a currently valid codepath in the memcpy_parameter overload, so long as the source & dest are represented as `pitched_data`. I added tests to ensure every other codepath raises a runtime_error for now. Signed-off-by: Joe Todd <joe.todd@codeplay.com>
Signed-off-by: Joe Todd <joe.todd@codeplay.com>
Signed-off-by: Joe Todd <joe.todd@codeplay.com>
Signed-off-by: Joe Todd <joe.todd@codeplay.com>
Signed-off-by: Joe Todd <joe.todd@codeplay.com>
|
@intel/llvm-gatekeepers this is ready to merge 🙏 CI failures unrelated |
The Windows failure seems to be in cleanup and so it should be alright to ignore and Jenkins seems to be infrastructural as well. However, the CUDA failure meant no CUDA tests were run, so I will retrigger it in the hopes that we can get some actual results there. 🤞 |
|
Looks like the CUDA device issue is expected to be fixed with #14074. We may have to push a merge commit for it to take effect once merged however. |
|
@intel/llvm-gatekeepers I believe this is ready to merge. Intel GEN12 failures appear unrelated. Unsure about |
|
Jenkins/Precommit is being weird, but rerunning the Gen12 Windows tests made them pass, so this is indeed good-to-go! |
…ds (intel#14039) This PR adds `syclcompat::experimental::memcpy` and `syclcompat::experimental::memcpy_async` taking `memcpy_parameter` arguments which wrap either: - deprecated `sycl::image` - experimental bindless images Since image support was decided to be out of scope for 2025.0, these APIs are introduced for forward compatibility only, and currently throw a `std::runtime_error`. --------- Signed-off-by: Joe Todd <joe.todd@codeplay.com>
4 participants
This PR adds
syclcompat::experimental::memcpyandsyclcompat::experimental::memcpy_asynctakingmemcpy_parameterarguments which wrap either:sycl::imageSince image support was decided to be out of scope for 2025.0, these APIs are introduced for forward compatibility only, and currently throw a
std::runtime_error.