Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFCI][ABI-Break] Move handler members to impl #14460
[SYCL][NFCI][ABI-Break] Move handler members to impl #14460
Changes from 23 commits
98c691c
5805367
8878682
e339faf
d93ef7b
4fa05e8
69abfe6
d1ca544
a2f49a5
5f99c91
8fdfcdd
ad2e20c
c389dc0
72f7fb6
dc76694
adf52d4
e51e47a
9b33cf5
1d9e1f5
a0aba15
628ee06
abb11cc
1a4f3a3
affd0ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, these changes makes MSVC think that this could potentially cause division by 0. However, this ctor cannot be called on host (since
group
is not usable on host) so these asserts carry no meaning.