-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Remove support of deprecated {121, 1.2.1, sycl-1.2.1, 2017} values for the sycl-std= argument #14544
Conversation
…ues for the sycl-std= argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to remove/adjust:
llvm/sycl/test-e2e/Sampler/basic-rw.cpp
Line 12 in 46528f9
clang++ -fsycl -sycl-std=121 -o binx.bin basic-rw.cpp The default value for this option is `1.2.1`. Line 136 in 46528f9
**`-sycl-std=<value>`** [EXPERIMENTAL] - many tests in clang/test/SemaSYCL/ still use removed values, as well as in in clang/test/Driver/ and clang/test/CodeGenSYCL/. Just grep for
-sycl-std
in the whole intel/llvm repo.
And I'm curious, how all these not removed tests are passing in pre-commit, if they still use removed values? Are we showing just some warning, and not an error, if user uses removed values for |
|
I'd be happy to know how many and which tests? I can't find such tests
I'm not sure the old release notes from 13 months ago and from 4 ago have to be modified
thanks a lot for highlighted places: |
Looks like I have outdated branch in which these tests are present.
Yes, of course release notes should not be modified, they are not in my list above. I cloned your repo to take a look closer: in the future, please don't create PR from |
A misunderstanding occurred due to the simultaneous use of different branches😅. I temporarily set an incorrect branch as the default in my fork, which did not correspond to the branch used for the #14544. As a result, an incorrect branch was utilized as default, leading to a discrepancy between the cloned files and the current state of the PR. For precision, I would recommend using a specific commit ID or the PR ID as the target to be checked out as the end of the cloning process. This approach is detailed in the following resource: https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request-with-git I trust this clarifies the situation 😄 |
As a continuation of #14261 this PR makes impossible to call clang with -sycl-std=2017 option as well as with 121, 1.2.1, sycl-1.2.1 values. It also removes some tests which are available only with support of 2017/121
The rest of cleanup is to be continued with next submissions