-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Turning off the deprecated attribute propagation and Sycl2017Compat option specification #14984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiZibrov
had a problem deploying
to
WindowsCILock
August 7, 2024 13:23
— with
GitHub Actions
Failure
AndreiZibrov
had a problem deploying
to
WindowsCILock
August 7, 2024 15:00
— with
GitHub Actions
Error
AndreiZibrov
had a problem deploying
to
WindowsCILock
August 7, 2024 15:51
— with
GitHub Actions
Error
AndreiZibrov
temporarily deployed
to
WindowsCILock
August 7, 2024 18:19
— with
GitHub Actions
Inactive
AndreiZibrov
temporarily deployed
to
WindowsCILock
August 7, 2024 21:00
— with
GitHub Actions
Inactive
elizabethandrews
approved these changes
Aug 14, 2024
smanna12
approved these changes
Aug 14, 2024
Hello @intel/llvm-gatekeepers, PR seems to be ready for merging |
I restarted CUDA testing, let's wait for that. |
yup. thanks. I did it few times. the logs are showing CUDA test has issues with starting |
@AndreiZibrov I think it was because the build ran > 3 days ago so the archive got deleted. I restarted the build too just now, should work this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a continuation of #14544 this PR turns off attribute propagation specified by sycl-1.2.1. It also removes rest of 2017/121 things like a definition of Sycl2017Compat which had been turned off in #14239