Skip to content

[SYCL] add diagnostics for long double in device code #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

cperkinsintel
Copy link
Contributor

added diagnostics for long double in SYCL kernels

Following a discussion with @bader and @andykaylor it was decided to issue an error whenever 'long double' is used in device code. Regardless, of whether the underlying representation is 64-bit or 80-bit.

Signed-off-by: Chris Perkins chris.perkins@intel.com

Signed-off-by: Chris Perkins <chris.perkins@intel.com>
@bader bader merged commit 62f841d into intel:sycl Apr 15, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 21, 2020
…c_abi_checks

* origin/sycl:
  [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545)
  [SYCL] [xmethods] Allow replacing xmethod script (intel#1532)
  [SYCL] Add tests for inline asm feature (intel#1444)
  [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540)
  [SYCL][USM] Remove unused header and unnecessary includes (intel#1537)
  Fix check-llvm dependencies (intel#1547)
  [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531)
  [SYCL][Doc] Add static local memory query extension. (intel#1539)
  [SYCL][Doc] Add sycl_bitcast extension (intel#1541)
  [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533)
  [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529)
  [SYCL] Fix processing of spec consts referenced twice (intel#1524)
  [SYCL] Use correct macro name in export.hpp (intel#1527)
  [Driver][NFC] Fix -help information for -Xs options (intel#1530)
  [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457)
  [SYCL] Add diagnostics for long double in device code (intel#1512)
  [SYCL] Add a mutex to state-modifying program functions (intel#1204)
  [SYCL][Test] Add Devicelib tests (intel#1256)
  [SYCL] Refactor semantic checks for variable types (intel#1513)
dwoodwor-intel pushed a commit to dwoodwor-intel/llvm that referenced this pull request Jul 8, 2022
…el#1512)

This change is incomplete, and will not properly convert every single LLVM IR
file to SPIR-V. However, it will convert many files. Areas that are known to
require more investigation:
* ptr-valued extractvalue, especially from cmpxchg instructions
* return values of functions
* llvm.*.annotation support
* function pointer extensions
* pointer types in structs

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@21fee92
@cperkinsintel cperkinsintel deleted the cperkins-long-double-diag branch September 13, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants