Skip to content

[SYCL][Doc] Add sycl_bitcast extension #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

felipepiovezan2
Copy link
Contributor

This commit adds the sycl_bitcast extension, introducing sycl::bit_cast with
the same semantics as C++20's std::bit_cast (p0476r2).

Signed-off-by: Felipe de Azevedo Piovezan felipe.de.azevedo.piovezan@intel.com

@mkinsner
Copy link

Please remove the SYCL from the directory that you're adding, to match the other extensions. This one should just be Bitcast, I think.

This commit adds the sycl_bitcast extension, introducing sycl::bit_cast with
the same semantics as C++20's std::bit_cast (p0476r2).

Signed-off-by: Felipe de Azevedo Piovezan <felipe.de.azevedo.piovezan@intel.com>
@felipepiovezan2 felipepiovezan2 force-pushed the private/fdeazeve/sycl_bit_cast branch from 614d14c to 555392c Compare April 16, 2020 22:50
@felipepiovezan2
Copy link
Contributor Author

Addressed Mike's comments.

@bader bader added the spec extension All issues/PRs related to extensions specifications label Apr 17, 2020
@bader bader merged commit a9ca0d9 into intel:sycl Apr 17, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 21, 2020
…c_abi_checks

* origin/sycl:
  [SYCL][Driver] Enforce unique filenames when -save-temps is used (intel#1545)
  [SYCL] [xmethods] Allow replacing xmethod script (intel#1532)
  [SYCL] Add tests for inline asm feature (intel#1444)
  [SYCL][Doc] Add device_specific_kernel_queries extension. (intel#1540)
  [SYCL][USM] Remove unused header and unnecessary includes (intel#1537)
  Fix check-llvm dependencies (intel#1547)
  [SYCL] Add __SYCL_EXPORT to declaration of contextSetExtendedDeleter (intel#1531)
  [SYCL][Doc] Add static local memory query extension. (intel#1539)
  [SYCL][Doc] Add sycl_bitcast extension (intel#1541)
  [SYCL][NFC] Temporarily disable sporadically failing test (intel#1533)
  [SYCL][NFC] Adjust codeowners for sycl directory (intel#1529)
  [SYCL] Fix processing of spec consts referenced twice (intel#1524)
  [SYCL] Use correct macro name in export.hpp (intel#1527)
  [Driver][NFC] Fix -help information for -Xs options (intel#1530)
  [SYCL][Doc] Add Graph Scheduler design documentation (intel#1457)
  [SYCL] Add diagnostics for long double in device code (intel#1512)
  [SYCL] Add a mutex to state-modifying program functions (intel#1204)
  [SYCL][Test] Add Devicelib tests (intel#1256)
  [SYCL] Refactor semantic checks for variable types (intel#1513)
bader pushed a commit to bader/llvm that referenced this pull request Jul 11, 2024
…el#1541)

1) find_program(), find_library(), find_path() is now called twice.
The 1st time with NO_DEFAULT_PATH to prioritize the CMAKE parameter
OCLOC_PACKAGE_DIR over the system paths like /usr/lib/libocloc.so
or /usr/include/ocloc_api.h
That is needed for those build-hosts that have ocloc installed into
system folders.

2) NFC: Fixed the build.md for the pISA project. 'gfx-driver' is used
instead of 'ocloc' after 78cf3c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec extension All issues/PRs related to extensions specifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants