Skip to content

Conversation

nrspruit
Copy link
Contributor

-pre-commit PR for oneapi-src/unified-runtime#2134

…from in order wait list

-pre-commit PR for oneapi-src/unified-runtime#2134

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@pbalcer pbalcer marked this pull request as ready for review September 26, 2024 08:54
@pbalcer pbalcer requested a review from a team as a code owner September 26, 2024 08:54
@pbalcer
Copy link
Contributor

pbalcer commented Sep 26, 2024

windows gen12 runner appears broken:

Run mkdir install
mkdir: cannot create directory 'install': File exists
Error: Process completed with exit code 1.

@aarongreig
Copy link
Contributor

@intel/llvm-gatekeepers the windows fail is due to a bad runner, are we still ok merging things while that's broken?

@steffenlarsen
Copy link
Contributor

@intel/llvm-gatekeepers the windows fail is due to a bad runner, are we still ok merging things while that's broken?

It seems like out CI systems have changed since last I had to handle this Windows runner issue, so sadly I can't do much about it until the people in the US who know wakes up.

I have concerns about merging this untested on Windows. How confident are we that these changes won't cause problems on Windows? Is it urgent or can it wait one more day? We could try another rerun and hope another machine gets picked up.

@aarongreig
Copy link
Contributor

I don't have any reason to believe this would be particularly safe to merge without windows testing, @pbalcer or @nrspruit can attest to whether it's sufficiently urgent to risk it

@steffenlarsen
Copy link
Contributor

It's green now!

@steffenlarsen steffenlarsen merged commit a72d8cf into intel:sycl Sep 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants