[L0] Fix Multi Device Event handling and remove unhandled events from in order wait list #2134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Sep 25, 2024
nrspruit
commented
- fix multi device event creation to be enqueued as a barrier waiting on the original event keeping the multi device event valid.
- Avoid wait on events on a multi device event given driver in order due to p2p errors for driver in order lists. Barrier from multi device event creation will guarantee in order execution.
… in order wait list - fix multi device event creation to be enqueued as a barrier waiting on the original event keeping the multi device event valid. - Avoid wait on events on a multi device event given driver in order due to p2p errors for driver in order lists. Barrier from multi device event creation will guarantee in order execution. Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Sep 25, 2024
…from in order wait list -pre-commit PR for oneapi-src/unified-runtime#2134 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
raiyanla
approved these changes
Sep 25, 2024
pbalcer
approved these changes
Sep 26, 2024
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Sep 27, 2024
…from in order wait list (#15516) -pre-commit PR for oneapi-src/unified-runtime#2134 --------- Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Piotr Balcer <piotr.balcer@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.