Fix urEnqueueEventsWaitWithBarrier when used with interop events #2117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This tests a scenario where a native interop event is used as part of a barrier. Current implementation fails because it skips waiting on events if the queue is using driver in order lists.
pbalcer
changed the title
pbalcer
force-pushed
the
fix-filter-out-same-cmdlists
branch
2 times, most recently
from
e962cf3 to
8da74a0
Compare
nrspruit
approved these changes
Sep 23, 2024
raiyanla
approved these changes
Sep 23, 2024
This patch makes sure that only events from the exact same cmdlists are filtered out when appending events to wait.
pbalcer
force-pushed
the
fix-filter-out-same-cmdlists
branch
from
8da74a0 to
96f66e0
Compare
nrspruit
added
v0.10.x
bader
reviewed
Sep 25, 2024
| // is unnecessary IF the cmdlists match. | ||
| if (EventWaitList.Length) { | ||
| if (CmdList->second.IsInOrderList) { | ||
| for (unsigned i = EventWaitList.Length; i-- < 0;) { |
There was a problem hiding this comment.
/unified-runtime-src/source/adapters/level_zero/event.cpp:203:55: warning: comparison of unsigned expression in ‘< 0’ is always false [-Wtype-limits]
203 | for (unsigned i = EventWaitList.Length; i-- < 0;) {
| ~~~~^~~
There was a problem hiding this comment.
Yup, we are aware of that typo. Thanks. This patch will solve the problem: #2134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes sure that only events from the exact same
cmdlists are filtered out when appending events to wait.