-
Notifications
You must be signed in to change notification settings - Fork 124
Fix for
in level_zero EventWaitList handling
#2130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pre-commit MR for: oneapi-src/unified-runtime#2130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
|
:| It was supposed to be >. How is this passing tests? |
Can a test be added to trigger this issue? It seems like maybe this entire case is currently missed (or would indeed surely be failing). |
I added a test for this code path, but what that test verified is that the correct events are not removed from the list, not whether the intended events are removed. So not removing any events makes the test pass :) This loop is intended to remove unneeded events from a waitlist. It's a performance optimization and may be needed to workaround (what I think is) a driver issue. |
preferred change: |
No description provided.