[SYCL][UR][L0] Fix urEnqueueEventsWait #18342
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path for non-immediate command lists was incorrect. queue->synchronize() was called without closing and executing command lists leading to deadlock. Fix this by replacing synchronize() call with executeCommandList()
for non-immediate command lists. Change the logic for empty wait list. Instead of blocking the host, just call zeCommandListAppendWaitOnEvents. It is defined as a synchronization points, which means that all operations submitted before must completed before the next operation (which is zeCommandListAppendSignalEvent).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.