[SYCL][UR][L0] Fix urEnqueueEventsWait #18343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
In theory, we shouldn't need to block the host, but when I tried calling zeCommandListAppendWaitOnEvents with empty wait list, there were a few llvm test failures: #18342 so for now, I think this fix should be OK. |
The path for non-immediate command lists was incorrect. queue->synchronize() was called without closing and executing command lists leading to deadlock. Fix this by add call to executeAllOpenCommandLists
igchor
force-pushed
the
legacy_fix_wait_events_blocking
branch
from
45cbc85 to
3e8e258
Compare
pbalcer
approved these changes
May 6, 2025
kbenzie
approved these changes
May 7, 2025
pbalcer
approved these changes
May 7, 2025
Contributor
|
CI failures look unrelated #18349 |
Contributor
Author
|
@intel/llvm-gatekeepers this should be ready for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path for non-immediate command lists was incorrect. queue->synchronize() was called without closing and executing command lists leading to deadlock.
Fix this by replacing synchronize() call with executeCommandList()