[SYCL][UR][L0 v2] fix mem buffer for integrated graphics #18345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ur_integrated_buffer_handle_t was missing logic for writing back memory to the hostPtr suplied during buffer construction. getDevicePtr and mapHostPtr did not take into account offset.
pbalcer
approved these changes
May 7, 2025
Contributor
pbalcer
left a comment
pbalcer
left a comment
There was a problem hiding this comment.
is this failing on an existing test on a platform not tested in CI?
Contributor
Author
Yes, there is llvm test failing but we don't test v2 on integrated GPU in recommit yet. As for UR tests - I don't think we test any adapter on integrated GPU. |
Contributor
Author
|
@intel/llvm-gatekeepers this should be ready for merge, the failures are not related: #18349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ur_integrated_buffer_handle_t was missing logic for writing back memory to the hostPtr suplied during buffer construction.
getDevicePtr and mapHostPtr did not take into account offset.