Skip to content

[SYCL][UR][L0 v2] fix mem buffer for integrated graphics #18345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kbenzie merged 1 commit into from
May 7, 2025
Merged

[SYCL][UR][L0 v2] fix mem buffer for integrated graphics #18345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions unified-runtime/source/adapters/level_zero/v2/memory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ ur_integrated_buffer_handle_t::ur_integrated_buffer_handle_t(

if (hostPtr) {
std::memcpy(this->ptr.get(), hostPtr, size);
writeBackPtr = hostPtr;
}
}
}
Expand All @@ -110,17 +111,23 @@ ur_integrated_buffer_handle_t::ur_integrated_buffer_handle_t(
});
}

ur_integrated_buffer_handle_t::~ur_integrated_buffer_handle_t() {
if (writeBackPtr) {
std::memcpy(writeBackPtr, this->ptr.get(), size);
}
}

void *ur_integrated_buffer_handle_t::getDevicePtr(
ur_device_handle_t /*hDevice*/, device_access_mode_t /*access*/,
size_t /*offset*/, size_t /*size*/,
size_t offset, size_t /*size*/,
std::function<void(void *src, void *dst, size_t)> /*migrate*/) {
return ptr.get();
return ur_cast<char *>(ptr.get()) + offset;
}

void *ur_integrated_buffer_handle_t::mapHostPtr(
ur_map_flags_t /*flags*/, size_t /*offset*/, size_t /*size*/,
ur_map_flags_t /*flags*/, size_t offset, size_t /*size*/,
std::function<void(void *src, void *dst, size_t)> /*migrate*/) {
return ptr.get();
return ur_cast<char *>(ptr.get()) + offset;
}

void ur_integrated_buffer_handle_t::unmapHostPtr(
Expand Down
3 changes: 3 additions & 0 deletions unified-runtime/source/adapters/level_zero/v2/memory.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,8 @@ struct ur_integrated_buffer_handle_t : ur_mem_buffer_t {
size_t size, device_access_mode_t accesMode,
bool ownHostPtr);

~ur_integrated_buffer_handle_t();

void *
getDevicePtr(ur_device_handle_t, device_access_mode_t, size_t offset,
size_t size,
Expand All @@ -98,6 +100,7 @@ struct ur_integrated_buffer_handle_t : ur_mem_buffer_t {

private:
usm_unique_ptr_t ptr;
void *writeBackPtr = nullptr;
};

struct host_allocation_desc_t {
Expand Down
Loading