-
Notifications
You must be signed in to change notification settings - Fork 802
[NFCI][SYCL] More use of CompileTimeKernelInfoTy/DeviceKernelInfo
#19929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NFCI][SYCL] More use of CompileTimeKernelInfoTy/DeviceKernelInfo
#19929
Conversation
adamfidel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for SYCL Graph LGTM
579f22d to
1a84537
Compare
|
I've forced pushed after rebasing on top of several smaller changes factored out from here. Doing the same via merges would have been much harder. SYCL Graphs changes in this PR were not affected by the rebase. |
|
llvm/sycl/include/sycl/detail/kernel_name_str_t.hpp Lines 17 to 25 in ed3767c
and some of our internal interfaces do expect const std::string & arguments. Creating those from std::string_view would result in otherwise unnecessary memory allocations.
On the other hand, I'd really prefer we do NOT introduce more ugly instances of |
Co-authored-by: Sergey Semenov <sergey.semenov@intel.com>
|
Jenkins failure (old RHEL/gcc) seems to have been caused by an earlier #19117, we probably had that part of CI not working back then. |
Additional cleanups enabled by #19117.