[SYCL][XPTI] Performance improvements for performance oriented toolchains #19953

tovinkere · 2025-09-02T23:20:25Z

Implementation of XPTI within SYCL combined debug and performance streams over time and this PR improves the performance by 15-20% for toolschains by separating the debug data from performance streams.

Limits the amount of debug information that is attached to the default "sycl" performance stream.
If addition metadata is needed, toolchains will have to subscribe to "sycl.debug" stream
Unified runtime created a new trace event for each function call which adds significant overhead to each call when a collector is enabled. This is now minimized by using a global event for all of UR API calls.
CUDA plugin implementation of XPTI events enabled both performance and debug streams all the time, irrespective of where there was a tool subscribing to the data.
If tools want good performance then they need to subscribe to "sycl" stream. If they want full information and performance is not as important then subscribing to "sycl.debug" stream is the right choice.

+ Improves the performance of collectors and downstream collectors by limiting the amount of metada that is attached to SYCL events + To get additional metadata, toolchains will have to also subscribe to the stream "sycl.debug" and the additional metadata will be sent in the orginal stream + Replaced all xptiMakeEvent() calls with the new xptiCreateTracepoint() function Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>

Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>

sycl/source/detail/global_handler.cpp

sycl/source/detail/queue_impl.cpp

unified-runtime/source/adapters/cuda/tracing.cpp

unified-runtime/source/loader/layers/tracing/ur_tracing_layer.cpp

Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>

againull · 2025-09-03T21:42:26Z

These failures are unrelated:

/__w/llvm/llvm/build/test/conformance/device/device-test --gtest_filter=urDeviceGetGlobalTimestampTest.SuccessSynchronizedTime/UR_BACKEND_HIP__AMD_HIP_BACKEND__AMD_Radeon_RX_6800_XT_ID0ID_5d5f47c5a7185748____
--
/__w/llvm/llvm/unified-runtime/test/conformance/device/urDeviceGetGlobalTimestamps.cpp:93: Failure
Expected: (observedDiff) <= (allowedDiff), actual: 254563 vs 81685

/__w/llvm/llvm/unified-runtime/test/conformance/device/urDeviceGetGlobalTimestamps.cpp:93
Expected: (observedDiff) <= (allowedDiff), actual: 254563 vs 81685

#18763

CMake Error: install(EXPORT "unified-runtime-targets" ...) includes target "xptifw" which requires target "emhash" that is not in any export set.
#19944

bratpiorka

CUDA LGTM

unified-runtime/source/loader/layers/tracing/ur_tracing_layer.cpp

againull · 2025-09-09T22:55:52Z

Jenkins failure is unrelated, see #19929 (comment)

pbalcer · 2025-09-11T13:17:50Z

sycl/doc/design/SYCLInstrumentationUsingXPTI.md


+- To support performance and debug streams, subscribing to the stream **"sycl.debug"**
+  allows the default streams to contain additional metadata when keeping overheads
+  to a minimum is not important


Suggested change

to a minimum is not important

to a minimum is not important.

sycl/doc/design/SYCLInstrumentationUsingXPTI.md

unified-runtime/source/loader/layers/tracing/ur_tracing_layer.cpp

pbalcer

UR lgtm.

mmichel11

Graph changes LGTM

againull · 2025-09-16T17:11:57Z

@sergey-semenov Could you please review this PR on behalf of @intel/llvm-reviewers-runtime. @maarquitos14 and @KseniyaTikhomirova are both on vacation at the moment.

tovinkere added 3 commits September 2, 2025 15:29

[SYCL][XPTI] Updated documentation and tests

77657de

Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>

Merge remote-tracking branch 'origin' into xpti_overheads

1b8337a

tovinkere requested review from a team as code owners September 2, 2025 23:20

tovinkere requested review from bratpiorka and maarquitos14 September 2, 2025 23:20

tovinkere temporarily deployed to WindowsCILock September 2, 2025 23:20 — with GitHub Actions Inactive

tovinkere had a problem deploying to WindowsCILock September 2, 2025 23:47 — with GitHub Actions Failure

tovinkere temporarily deployed to WindowsCILock September 2, 2025 23:47 — with GitHub Actions Inactive

[SYCL][XPTI] Ensure all tests subscribe to debug stream

15a3e7b

Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>

tovinkere temporarily deployed to WindowsCILock September 3, 2025 04:30 — with GitHub Actions Inactive

tovinkere had a problem deploying to WindowsCILock September 3, 2025 04:58 — with GitHub Actions Failure

tovinkere temporarily deployed to WindowsCILock September 3, 2025 04:58 — with GitHub Actions Inactive

maarquitos14 reviewed Sep 3, 2025

View reviewed changes

[SYCL][XPTI] Addressed reviewer-1 comments

604459f

Signed-off-by: Vasanth Tovinkere <vasanth.tovinkere@intel.com>

tovinkere temporarily deployed to WindowsCILock September 3, 2025 18:44 — with GitHub Actions Inactive

tovinkere temporarily deployed to WindowsCILock September 3, 2025 19:10 — with GitHub Actions Inactive

bratpiorka approved these changes Sep 4, 2025

View reviewed changes

pbalcer reviewed Sep 5, 2025

View reviewed changes

unified-runtime/source/loader/layers/tracing/ur_tracing_layer.cpp Show resolved Hide resolved

unified-runtime/source/loader/layers/tracing/ur_tracing_layer.cpp Show resolved Hide resolved

againull added 3 commits September 5, 2025 10:35

Merge remote-tracking branch 'origin/sycl' into xpti_overheads_local

556f03a

Fix unused variable error

ff02fce

Use kernel name is function name is not available

e6e88cb

againull had a problem deploying to WindowsCILock September 5, 2025 19:39 — with GitHub Actions Error

Avoid duplicate code

a1b2718

againull temporarily deployed to WindowsCILock September 5, 2025 19:47 — with GitHub Actions Inactive

againull temporarily deployed to WindowsCILock September 5, 2025 20:13 — with GitHub Actions Inactive

againull requested a review from pbalcer September 9, 2025 15:59

againull had a problem deploying to WindowsCILock September 9, 2025 16:32 — with GitHub Actions Failure

againull temporarily deployed to WindowsCILock September 9, 2025 16:32 — with GitHub Actions Inactive

Merge remote-tracking branch 'origin/sycl' into wip/xpti_overheads

e0f56b0

againull temporarily deployed to WindowsCILock September 9, 2025 18:49 — with GitHub Actions Inactive

againull temporarily deployed to WindowsCILock September 9, 2025 19:34 — with GitHub Actions Inactive

againull requested a review from maarquitos14 September 9, 2025 20:30

pbalcer reviewed Sep 11, 2025

View reviewed changes

againull added 3 commits September 15, 2025 21:12

Merge remote-tracking branch 'origin/sycl' into wip/xpti_overheads

1faf588

Make sycl.debug a normal stream

9cf8476

Update documentation

a4de171

againull requested a review from a team as a code owner September 16, 2025 06:47

againull requested a review from mmichel11 September 16, 2025 06:47

againull temporarily deployed to WindowsCILock September 16, 2025 06:47 — with GitHub Actions Inactive

againull requested a review from pbalcer September 16, 2025 06:49

againull temporarily deployed to WindowsCILock September 16, 2025 07:15 — with GitHub Actions Inactive

pbalcer approved these changes Sep 16, 2025

View reviewed changes

mmichel11 approved these changes Sep 16, 2025

View reviewed changes

againull added 2 commits September 16, 2025 09:02

Register all callbacks for debug stream as it is a normal stream now

f4b11b8

Merge remote-tracking branch 'origin/sycl' into wip/xpti_overheads

d0ee4a5

againull temporarily deployed to WindowsCILock September 16, 2025 16:09 — with GitHub Actions Inactive

againull temporarily deployed to WindowsCILock September 16, 2025 16:35 — with GitHub Actions Inactive

againull requested a review from sergey-semenov September 16, 2025 17:10

maarquitos14 approved these changes Sep 22, 2025

View reviewed changes

againull merged commit 1ebd224 into intel:sycl Sep 22, 2025
74 of 77 checks passed

[SYCL][XPTI] Performance improvements for performance oriented toolchains #19953

[SYCL][XPTI] Performance improvements for performance oriented toolchains #19953

Uh oh!

Conversation

tovinkere commented Sep 2, 2025 • edited by againull Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

againull commented Sep 3, 2025

Uh oh!

bratpiorka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

againull commented Sep 9, 2025

Uh oh!

pbalcer Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pbalcer left a comment

Choose a reason for hiding this comment

Uh oh!

mmichel11 left a comment

Choose a reason for hiding this comment

Uh oh!

againull commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tovinkere commented Sep 2, 2025 •

edited by againull

Loading

againull commented Sep 16, 2025 •

edited

Loading