-
Notifications
You must be signed in to change notification settings - Fork 802
[SYCL][Doc] Simpler free function kernel enqueue #19995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify a simplified way to enqueue free function kernels without first getting a kernel bundle. The style follows the enqueue functions in "sycl_ext_oneapi_enqueue_functions". Once the KHR extension "sycl_khr_free_function_commands" is finalized, we may also add enqueue functions that follow that style. However, we will first need to extend the `requirements` in that KHR to accept kernel launch properties.
gmlueck
commented
Sep 5, 2025
sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc
Show resolved
Hide resolved
sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc
Show resolved
Hide resolved
Move this note earlier in the specification, so it appears before all APIs that take a `Func` parameter.
steffenlarsen
approved these changes
Sep 30, 2025
Contributor
steffenlarsen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor
|
@intel/llvm-gatekeepers please consider merging |
3 similar comments
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Contributor
Author
|
@intel/llvm-gatekeepers I think this is ready to merge. |
sarnex
pushed a commit
that referenced
this pull request
Dec 17, 2025
Implement the new enqueue functions for free function kernels that were added in #19995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify a simplified way to enqueue free function kernels without first getting a kernel bundle. The style follows the enqueue functions in "sycl_ext_oneapi_enqueue_functions".
Once the KHR extension "sycl_khr_free_function_commands" is finalized, we may also add enqueue functions that follow that style. However, we will first need to extend the
requirementsin that KHR to accept kernel launch properties.