Skip to content

[SYCL] Implement free function kernel enqueue functions #20698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarnex merged 26 commits into from
Dec 17, 2025
Merged

[SYCL] Implement free function kernel enqueue functions #20698

sarnex merged 26 commits into from
Dec 17, 2025
+251 −0

Conversation

@lbushi25
Copy link
Contributor

@lbushi25 lbushi25 commented Nov 20, 2025

Implement the new enqueue functions for free function kernels that were added in #19995

@lbushi25 lbushi25 requested a review from a team as a code owner November 20, 2025 05:55
@lbushi25
Copy link
Contributor Author

lbushi25 commented Dec 11, 2025

@vinser52 ping for review. I went with an approach where I wrap the free function in a lambda in order to exploit the already existing infrastructure for direct submission of lambda kernels. The wrapper lambda itself is very lightweight.

vinser52
vinser52 reviewed Dec 15, 2025
View reviewed changes
@lbushi25 lbushi25 requested a review from vinser52 December 15, 2025 16:42
@lbushi25
Copy link
Contributor Author

lbushi25 commented Dec 17, 2025 •
edited
Loading

@intel/llvm-gatekeepers Please consider merging this PR. There are outstanding requested changes left by Andrei but they are stale as I rewrote the PR to circumvent the problems outlined there and he is currently on vacation until next year. The approval of @vinser52, who was tagged by Andrei to review this PR, should attest to this.

@sarnex sarnex merged commit a37b3cf into intel:sycl Dec 17, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlueck gmlueck gmlueck left review comments

@slawekptak slawekptak slawekptak left review comments

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@vinser52 vinser52 vinser52 approved these changes

@aelovikov-intel aelovikov-intel Awaiting requested review from aelovikov-intel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@lbushi25 @cperkinsintel @gmlueck @vinser52 @slawekptak @aelovikov-intel @sarnex