Skip to content

[UR][L0v2] Verify number and indices of kernel arguments #21242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sarnex merged 1 commit into from
Feb 11, 2026
Merged

[UR][L0v2] Verify number and indices of kernel arguments #21242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sycl/test-e2e/Graph/Explicit/regression_accessor_spv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,10 @@ int main(int, char **argv) {

Graph.add([&](handler &cgh) {
auto Acc = BufA.get_access(cgh);

// the kernel requires two arguments, the second one is an offset which is
// set to 0 here
cgh.set_arg(0, Acc);
cgh.set_arg(1, 0); // offset
cgh.single_task(kernel);
});

Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Update/dyn_cgf_accessor_spv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ int main(int, char **argv) {

int PatternA = 42;
int PatternB = 0xA;
int AccOffset = 0;

auto AccA = BufA.get_access();
auto AccB = BufB.get_access();
Expand All @@ -52,13 +53,15 @@ int main(int, char **argv) {
auto CGFA = [&](handler &CGH) {
CGH.require(AccA);
CGH.set_arg(0, AccA);
CGH.set_arg(1, AccOffset);
CGH.set_arg(2, PatternA);
CGH.parallel_for(sycl::range<1>(Size), kernelA);
};

auto CGFB = [&](handler &CGH) {
CGH.require(AccB);
CGH.set_arg(0, AccB);
CGH.set_arg(1, AccOffset);
CGH.set_arg(2, PatternB);
CGH.parallel_for(sycl::range<1>(Size), kernelB);
};
Expand Down
3 changes: 3 additions & 0 deletions sycl/test-e2e/Graph/Update/update_with_indices_accessor_spv.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,10 @@ int main(int, char **argv) {

auto KernelNode = Graph.add([&](handler &cgh) {
cgh.require(InputParam);
// the kernel requires two arguments, the second one is an offset which is
// set to 0 here
cgh.set_arg(0, InputParam);
cgh.set_arg(1, 0); // offset
cgh.single_task(kernel);
});

Expand Down
14 changes: 14 additions & 0 deletions unified-runtime/source/adapters/level_zero/v2/command_list_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,6 +1172,13 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExpNew(
const ur_kernel_launch_ext_properties_t *launchPropList,
wait_list_view &waitListView, ur_event_handle_t phEvent) {

if (numArgs != hKernel->getCommonProperties().numKernelArgs) {
setErrorMessage("Wrong number of kernel arguments",
UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX,
static_cast<int32_t>(ZE_RESULT_ERROR_INVALID_ARGUMENT));
return UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX;
}

ur_result_t checkResult = kernelLaunchChecks(hKernel, workDim);
if (checkResult != UR_RESULT_SUCCESS) {
return checkResult;
Expand Down Expand Up @@ -1219,6 +1226,13 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExpNew(
hKernel->kernelArgs.resize(numArgs, 0);

for (uint32_t argIndex = 0; argIndex < numArgs; argIndex++) {
if (pArgs[argIndex].index != argIndex) {
setErrorMessage("Missing kernel argument",
UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX,
static_cast<int32_t>(ZE_RESULT_ERROR_INVALID_ARGUMENT));
return UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_INDEX;
}

switch (pArgs[argIndex].type) {
case UR_EXP_KERNEL_ARG_TYPE_LOCAL:
hKernel->kernelArgs[argIndex] =
Expand Down