[UR][L0v2] Verify number and indices of kernel arguments by ldorau · Pull Request #21242 · intel/llvm

ldorau · 2026-02-09T15:44:36Z

Verify number and indices of kernel arguments and
fix three SYCL E2E tests with incorrect number of kernel arguments:

Graph/Explicit/regression_accessor_spv.cpp
Graph/Update/dyn_cgf_accessor_spv.cpp
Graph/Update/update_with_indices_accessor_spv.cpp

Ref: #21235

ldorau · 2026-02-11T11:41:56Z

@adamfidel please review

ldorau · 2026-02-11T12:56:47Z

@intel/sycl-graphs-reviewers @intel/unified-runtime-reviewers-level-zero please review

ldorau · 2026-02-11T13:25:33Z

The CUDA test fails because of #19688
The HIP test fails because of #18763

sycl/test-e2e/Graph/Update/dyn_cgf_accessor_spv.cpp

adamfidel

LGTM after the changes to the offset. Thanks!

sycl/test-e2e/Graph/Explicit/regression_accessor_spv.cpp

…intel#21236)" This reverts commit 9b36da3. The issue intel#21235 has been fixed by intel#21242. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

Verify number and indices of kernel arguments. Fix three SYCL E2E tests with incorrect number of kernel arguments. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau · 2026-02-11T19:50:32Z

The AMD/HIP CI job fails because of docker pull issues:

  failed commit on ref "layer-sha256:56951268789ec1853746009e178a2873cfaa4be1c71e57f188930ad8c7c8ad12": commit failed: lease does not exist: not found
  Warning: Docker pull failed with exit code 1, back off 1.435 seconds before retry.

ldorau · 2026-02-11T21:55:32Z

@intel/llvm-gatekeepers please merge

…intel#21236)" This reverts commit 9b36da3. The issue intel#21235 has been fixed by intel#21242. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

…#21236)" (#21266) This reverts commit 9b36da3. The issue #21235 has been fixed by #21242. Closes: #21235 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

Validate hKernel before dereferencing it. Ref: intel#21242 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

Validate hKernel before dereferencing it. Ref: #21242 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau had a problem deploying to WindowsCILock February 9, 2026 15:44 — with GitHub Actions Failure

ldorau force-pushed the Verify_number_and_indices_of_kernel_arguments branch from ae202eb to 8a8716d Compare February 9, 2026 15:54

ldorau temporarily deployed to WindowsCILock February 9, 2026 15:54 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock February 9, 2026 16:19 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock February 9, 2026 16:19 — with GitHub Actions Failure

ldorau had a problem deploying to WindowsCILock February 9, 2026 20:07 — with GitHub Actions Failure

ldorau changed the title ~~[UR][L0v2] Verify number and indices of kernel arguments~~ [UR][L0v2] Verify indices of kernel arguments Feb 9, 2026

ldorau force-pushed the Verify_number_and_indices_of_kernel_arguments branch from 8a8716d to e319096 Compare February 9, 2026 20:10

ldorau temporarily deployed to WindowsCILock February 9, 2026 20:10 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock February 9, 2026 20:28 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock February 9, 2026 20:28 — with GitHub Actions Failure

ldorau temporarily deployed to WindowsCILock February 9, 2026 20:28 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock February 9, 2026 21:14 — with GitHub Actions Failure

ldorau force-pushed the Verify_number_and_indices_of_kernel_arguments branch from e319096 to e861d38 Compare February 9, 2026 21:20

ldorau temporarily deployed to WindowsCILock February 9, 2026 21:20 — with GitHub Actions Inactive

ldorau mentioned this pull request Feb 9, 2026

[CI] Setup vulkan env for building e2e tests #21247

Merged

ldorau temporarily deployed to WindowsCILock February 9, 2026 21:46 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock February 9, 2026 22:00 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock February 9, 2026 22:00 — with GitHub Actions Failure

ldorau force-pushed the Verify_number_and_indices_of_kernel_arguments branch from e861d38 to b82f02d Compare February 10, 2026 07:08

ldorau temporarily deployed to WindowsCILock February 10, 2026 07:08 — with GitHub Actions Inactive

ldorau temporarily deployed to WindowsCILock February 10, 2026 07:34 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock February 10, 2026 07:34 — with GitHub Actions Failure

ldorau temporarily deployed to WindowsCILock February 10, 2026 07:40 — with GitHub Actions Inactive

ldorau mentioned this pull request Feb 11, 2026

Graph/Explicit/regression_accessor_spv.cpp crashing on PVC #21235

Closed

ldorau requested a review from adamfidel February 11, 2026 11:41

ldorau temporarily deployed to WindowsCILock February 11, 2026 11:59 — with GitHub Actions Inactive

pbalcer approved these changes Feb 11, 2026

View reviewed changes

mmichel11 reviewed Feb 11, 2026

View reviewed changes

sycl/test-e2e/Graph/Update/dyn_cgf_accessor_spv.cpp Outdated Show resolved Hide resolved

mmichel11 mentioned this pull request Feb 11, 2026

[SYCL][Graph][E2E] Add missing set_arg call to dyn_cgf_accessor_spv.cpp #21256

Closed

ldorau force-pushed the Verify_number_and_indices_of_kernel_arguments branch from 7fa5767 to 279a69a Compare February 11, 2026 15:34

ldorau temporarily deployed to WindowsCILock February 11, 2026 15:34 — with GitHub Actions Inactive

adamfidel approved these changes Feb 11, 2026

View reviewed changes

mmichel11 reviewed Feb 11, 2026

View reviewed changes

sycl/test-e2e/Graph/Explicit/regression_accessor_spv.cpp Show resolved Hide resolved

ldorau temporarily deployed to WindowsCILock February 11, 2026 15:52 — with GitHub Actions Inactive

ldorau had a problem deploying to WindowsCILock February 11, 2026 15:52 — with GitHub Actions Failure

ldorau temporarily deployed to WindowsCILock February 11, 2026 15:52 — with GitHub Actions Inactive

ldorau mentioned this pull request Feb 11, 2026

Revert "[SYCL][Graph][E2E] Disable regression_accessor_spv.cpp on PVC (#21236)" #21266

Merged

ldorau temporarily deployed to WindowsCILock February 11, 2026 16:00 — with GitHub Actions Inactive

[UR][L0v2] Verify number and indices of kernel arguments

279a69a

Verify number and indices of kernel arguments. Fix three SYCL E2E tests with incorrect number of kernel arguments. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

sarnex merged commit ddbad8b into intel:sycl Feb 11, 2026
191 of 202 checks passed

ldorau added a commit to ldorau/llvm that referenced this pull request Feb 13, 2026

[UR][L0v2] Fix: validate hKernel before dereferencing it

4f83695

Validate hKernel before dereferencing it. Ref: intel#21242 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

ldorau mentioned this pull request Feb 13, 2026

[UR][L0v2] Fix: validate hKernel before dereferencing it #21283

Merged

kswiecicki pushed a commit that referenced this pull request Feb 16, 2026

[UR][L0v2] Fix: validate hKernel before dereferencing it (#21283)

46b9718

Validate hKernel before dereferencing it. Ref: #21242 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[UR][L0v2] Verify number and indices of kernel arguments#21242

[UR][L0v2] Verify number and indices of kernel arguments#21242
sarnex merged 1 commit intointel:syclfrom
ldorau:Verify_number_and_indices_of_kernel_arguments

ldorau commented Feb 9, 2026 •

edited

Loading

Uh oh!

ldorau commented Feb 11, 2026

Uh oh!

ldorau commented Feb 11, 2026

Uh oh!

ldorau commented Feb 11, 2026 •

edited

Loading

Uh oh!

Uh oh!

adamfidel left a comment

Uh oh!

Uh oh!

ldorau commented Feb 11, 2026 •

edited

Loading

Uh oh!

ldorau commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

ldorau commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldorau commented Feb 11, 2026

Uh oh!

ldorau commented Feb 11, 2026

Uh oh!

ldorau commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

adamfidel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ldorau commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldorau commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

ldorau commented Feb 9, 2026 •

edited

Loading

ldorau commented Feb 11, 2026 •

edited

Loading

ldorau commented Feb 11, 2026 •

edited

Loading