[SYCL][Graph][E2E] Add missing set_arg call to dyn_cgf_accessor_spv.cpp#21256
Closed
mmichel11 wants to merge 1 commit intointel:syclfrom
Closed
[SYCL][Graph][E2E] Add missing set_arg call to dyn_cgf_accessor_spv.cpp#21256mmichel11 wants to merge 1 commit intointel:syclfrom
mmichel11 wants to merge 1 commit intointel:syclfrom
Conversation
We were previously relying on undefined behavior where kernel argument 1 was being set to 0 until kernels were switched to be launched with urEnqueueKernelLaunchWithArgsExp.
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
Closing in favor of #21242 which adjusts others tests with this issue as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dyn_cgf_accessor_spv.cppwas previously relying on UB to set arg index 1 to 0 when the kernel is launched. To fix, this we explicitly callhandler::set_arg.