Conversation
opensource-krzysztof
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
opensource-krzysztof
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
opensource-krzysztof
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
opensource-krzysztof
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
opensource-krzysztof
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
| image_options: -u 1001 --gpus all --cap-add SYS_ADMIN | ||
| target_devices: cuda:gpu | ||
| - name: AMD/HIP | ||
| runner: '["Linux", "amdgpu"]' |
There was a problem hiding this comment.
I think you also need to remove these from sycl-nightly.yml in the same folder.
There was a problem hiding this comment.
Do we want to build the compiler and libraries for AMD/GPU?
If no, please, remove --hip flag from
There was a problem hiding this comment.
Addition to the comment above.
also from these places:
llvm/.github/workflows/sycl-nightly.yml
Line 43 in d300163
llvm/.github/workflows/sycl-nightly.yml
Line 60 in d300163
There was a problem hiding this comment.
Yeah my understanding of the decision is we should also don't need to build on hip anymore, so we can remove --hip everywhere.
There was a problem hiding this comment.
IMO, we should keep the builds running for one more quarter or so. It doesn't cost much, and it would make it easier if we ever want to re-enable AMD testing. I think disabling the build should be a separate next step, followed by a third one: removing the AMD-specific code.
There was a problem hiding this comment.
@bratpiorka Just to be clear, if we keep the build running, that means we will have to resolve/support the building (especially libclc integrations -- there are lots of AMD specific libclc refactoring upstream will come very soon), we can keep the build if team are OK with supporting that.
|
How about: "[CI] Remove AMD/HIP support" -> "[CI] Disable testing on AMD GPU"? |
6 participants
No description provided.