Skip to content

[CI] Disable testing on AMD GPU #21263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opensource-krzysztof wants to merge 6 commits into
base: sycl
Choose a base branch
from
+3 −16
Open

[CI] Disable testing on AMD GPU #21263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
152ebd7
Remove AMD/HIP support
opensource-krzysztof Feb 11, 2026
b9ae622
Update ur-precommit.yml
opensource-krzysztof Feb 11, 2026
9c7901c
Update sycl-linux-precommit.yml
opensource-krzysztof Feb 18, 2026
2617888
Update sycl-linux-build.yml
opensource-krzysztof Feb 18, 2026
5959b31
Update sycl-nightly.yml
opensource-krzysztof Feb 18, 2026
3b18d5d
Update sycl-nightly.yml
opensource-krzysztof Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/sycl-linux-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:
build_configure_extra_args:
type: string
required: false
default: "--hip --cuda --native_cpu"
default: "--cuda --native_cpu"
build_target:
type: string
required: false
Expand Down
10 changes: 0 additions & 10 deletions .github/workflows/sycl-linux-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,6 @@ jobs:
runner: '["Linux", "cuda"]'
image_options: -u 1001 --gpus all --cap-add SYS_ADMIN
target_devices: cuda:gpu
- name: AMD/HIP
runner: '["Linux", "amdgpu"]'
Copy link
Contributor

@sarnex sarnex Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also need to remove these from sycl-nightly.yml in the same folder.

Copy link
Contributor

@bader bader Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to build the compiler and libraries for AMD/GPU?
If no, please, remove --hip flag from

llvm/.github/workflows/sycl-linux-build.yml

Line 35 in b9ae622

default: "--hip --cuda --native_cpu"
.

Copy link
Contributor

@KornevNikita KornevNikita Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addition to the comment above.
also from these places:

llvm/.github/workflows/sycl-nightly.yml

Line 43 in d300163

build_configure_extra_args: '--hip --cuda -DSYCL_BUILD_INFO="Nightly ${{ needs.get_date.outputs.date }}"'

llvm/.github/workflows/sycl-nightly.yml

Line 60 in d300163

build_configure_extra_args: '--shared-libs --hip --cuda --native_cpu --no-assertions'

Copy link
Contributor

@sarnex sarnex Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah my understanding of the decision is we should also don't need to build on hip anymore, so we can remove --hip everywhere.

Copy link
Contributor

@bratpiorka bratpiorka Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should keep the builds running for one more quarter or so. It doesn't cost much, and it would make it easier if we ever want to re-enable AMD testing. I think disabling the build should be a separate next step, followed by a third one: removing the AMD-specific code.

Copy link
Contributor

@sarnex sarnex Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsji What's your opinion on the above? Thx

Copy link
Contributor

@jsji jsji Feb 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bratpiorka Just to be clear, if we keep the build running, that means we will have to resolve/support the building (especially libclc integrations -- there are lots of AMD specific libclc refactoring upstream will come very soon), we can keep the build if team are OK with supporting that.

Copy link
Contributor

@bratpiorka bratpiorka Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsji zthanks, I understand. If keeping the builds enabled has a non‑zero cost, then we should disable the build as well. @opensource-krzysztof please apply the necessary changes

image_options: -u 1001 --device=/dev/dri --device=/dev/kfd
target_devices: hip:gpu
extra_lit_opts: -j 1
- name: Intel / Arc A-Series Graphics
runner: '["Linux", "arc"]'
target_devices: level_zero:gpu;opencl:gpu;level_zero_v2:gpu
Expand Down Expand Up @@ -256,11 +251,6 @@ jobs:
runner: '["Linux", "cuda"]'
image_options: -u 1001 --gpus all --cap-add SYS_ADMIN
target_devices: cuda:gpu
- name: AMD/HIP
runner: '["Linux", "amdgpu"]'
image_options: -u 1001 --device=/dev/dri --device=/dev/kfd
target_devices: hip:gpu
extra_lit_opts: -j 1

uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/sycl-nightly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
secrets: inherit
with:
build_cache_root: "/__w/"
build_configure_extra_args: '--hip --cuda -DSYCL_BUILD_INFO="Nightly ${{ needs.get_date.outputs.date }}"'
build_configure_extra_args: '--cuda -DSYCL_BUILD_INFO="Nightly ${{ needs.get_date.outputs.date }}"'
Copy link
Contributor

@sarnex sarnex Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few AMD testing jobs in this file, probably you want to remove them

build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest

retention-days: 90
Expand All @@ -57,7 +57,7 @@ jobs:
with:
build_cache_root: "/__w/"
build_cache_suffix: sprod_shared
build_configure_extra_args: '--shared-libs --hip --cuda --native_cpu --no-assertions'
build_configure_extra_args: '--shared-libs --cuda --native_cpu --no-assertions'
build_target: all

toolchain_artifact: sycl_linux_sprod_shared
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ur-precommit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,6 @@ jobs:
runner: UR_L0
other_adapter: NATIVE_CPU
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN
- name: HIP
runner: UR_HIP
image_options: -u 1001 --device=/dev/dri --device=/dev/kfd --cap-add=SYS_ADMIN
- name: CUDA
runner: UR_CUDA
image_options: -u 1001 --privileged --cap-add SYS_ADMIN --gpus all
Expand Down
Loading