Skip to content

[SYCL] Move sycl.hpp in install directory #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

pvchupin
Copy link
Contributor

@pvchupin pvchupin commented Apr 9, 2021

  • Moved from include/sycl/sycl/sycl.hpp to include/sycl/sycl.hpp
  • include/sycl/CL/sycl.hpp stay intact to avoid breaking change for users

Signed-off-by: Pavel V Chupin pavel.v.chupin@intel.com

* Moved from include/sycl/sycl/sycl.hpp to include/sycl/sycl.hpp
* include/sycl/CL/sycl.hpp stay intact to avoid breaking change for users

Signed-off-by: Pavel V Chupin <pavel.v.chupin@intel.com>
@pvchupin pvchupin requested a review from a team as a code owner April 9, 2021 05:58
@pvchupin pvchupin requested a review from dm-vodopyanov April 9, 2021 05:58
@pvchupin
Copy link
Contributor Author

pvchupin commented Apr 9, 2021

Few LIT tests fails on this revision. It looks like compiler driver adds include/sycl automatically into includes lookup. We should either extend it or add explicitly to tests.
@mdtoguchi can you confirm?

Copy link
Contributor

@dm-vodopyanov dm-vodopyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only remaining problem is outdated include paths in the driver.

@dm-vodopyanov dm-vodopyanov requested a review from mdtoguchi April 9, 2021 09:47
@mdtoguchi
Copy link
Contributor

Driver adds search directory "-internal-isystem" "<installdir>/bin/../include/sycl"

@mdtoguchi
Copy link
Contributor

I created a draft PR here: #3523
This contains these changes and additional driver changes to add the 'include' directory. I also updated the tests so the 'CL' location is properly found.

@pvchupin
Copy link
Contributor Author

pvchupin commented Apr 9, 2021

Abandoning in favor of #3523

@pvchupin pvchupin closed this Apr 9, 2021
@pvchupin pvchupin deleted the sycl-header branch April 9, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants