Skip to content

[SYCL] Move sycl.hpp in install directory and adjust driver to match #3523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

mdtoguchi
Copy link
Contributor

Default location in which the driver adds the header searches for sycl
headers is 'include/sycl'. With the change to the location of sycl.hpp
we also need to adjust (add) the 'include' location for default searches

Also update tests to reflect being able to find the 'CL' dir with new
%sycl_include setting

Default location in which the driver adds the header searches for sycl
headers is 'include/sycl'.  With the change to the location of sycl.hpp
we also need to adjust (add) the 'include' location for default searches

Also update tests to reflect being able to find the 'CL' dir with new
%sycl_include setting
Copy link
Contributor

@pvchupin pvchupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll abandon my change #3517 in favor of this one which is more complete.

@mdtoguchi mdtoguchi marked this pull request as ready for review April 9, 2021 19:21
@mdtoguchi mdtoguchi requested review from AGindinson and a team as code owners April 9, 2021 19:21
@mdtoguchi mdtoguchi requested a review from vladimirlaz April 9, 2021 19:21
AGindinson
AGindinson previously approved these changes Apr 9, 2021
Copy link
Contributor

@AGindinson AGindinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is testing this within Driver LITs an overkill? I don't have an opinion on this myself, so just bringing this up in case that's actually important.

@mdtoguchi
Copy link
Contributor Author

Is testing this within Driver LITs an overkill? I don't have an opinion on this myself, so just bringing this up in case that's actually important.

I'll augment an existing test to check for the additional search dir.

pvchupin
pvchupin previously approved these changes Apr 9, 2021
@mdtoguchi mdtoguchi dismissed stale reviews from pvchupin and AGindinson via 1dcf0b2 April 9, 2021 19:50
@pvchupin pvchupin merged commit 24d179c into intel:sycl Apr 11, 2021
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Apr 14, 2021
* upstream/sycl: (39 commits)
  [CI] Switch to default clang-format version. (intel#3540)
  [Driver][NFC] Cleanup some option setting for SYCL offload (intel#3542)
  [GitHub Actions] Update main branch sync schedule
  [SYCL][NFC] Fix potential namespace conflicts with PSTL in tuple.hpp (intel#3541)
  [SYCL] Bump sycl library minor version (intel#3538)
  [SYCL][CUDA] Implemented cuda_piextUSMEnqueueMemAdvise (intel#3365)
  [SYCL][FPGA] Add mutual diagnostic of max_concurrency attribute in conjunction of disable_loop_pipelining attribute (intel#3512)
  [SYCL] [MATRIX] Enable joint_matrix_load, joint_matrix_store, and joint_matrix_mad for AMX (intel#3503)
  [ESIMD] Skip rewriting functions used through function pointers (intel#3527)
  [SYCL] Fix address space for spec constants buffer (intel#3521)
  [SYCL] Correct the tablegen for checking mutually exclusive stmt attrs (intel#3519)
  [SYCL][PI][L0][NFC] Refactor setting of LastCommandEvent (intel#3528)
  [SYCL] Fix group local memory sharing issue (intel#3489)
  [SYCL][NFC] Fix post-commit failure (intel#3532)
  [SYCL][Doc] Remove extension mechanism (intel#3526)
  [SYCL] Move sycl.hpp in install directory and adjust driver to match (intel#3523)
  [SYCL][ESIMD] Update ESIMD docs to address recent user comments: (intel#3516)
  [NFCI][SYCL] Correct -fdeclare-spirv-builtins to use marshalling (intel#3515)
  [SYCL] Rework MarkDevice and children (intel#3475)
  [SYCL] Fix StringLiteral Ctor issue from intel#3504. (intel#3520)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants