[NFC][SYCL] Fix some uses of stringref& and qualtype& #3504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Identified elsewhere, these are a few cases of 'simple' types that are intended to be copied being passed around as const references. This patch just replaces them. Also, StringRefs for can be just llvm::StringLiteral for literals, since that does constexpr construction.
erichkeane
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
AaronBallman
previously approved these changes
Apr 7, 2021
I'm the worst, so I have another big patch coming as soon as it validates ;) We can't lose 'llvm::StringLiteral' unfortunately, since clang::StringLiteral is a thing. |
… constexpr construction
Co-authored-by: Aaron Ballman <aaron@aaronballman.com>
premanandrao
approved these changes
Apr 7, 2021
bader
reviewed
Apr 9, 2021
| template <size_t N> | ||
| static constexpr DeclContextDesc MakeDeclContextDesc(Decl::Kind K, | ||
| const char (&Str)[N]) { | ||
| return DeclContextDesc{K, llvm::StringLiteral{Str}}; |
There was a problem hiding this comment.
Clang doesn't compile this code:
/home/runner/work/llvm/llvm/src/clang/lib/Sema/SemaSYCL.cpp:76:31: error: no matching constructor for initialization of 'llvm::StringLiteral'
return DeclContextDesc{K, llvm::StringLiteral{Str}};
There was a problem hiding this comment.
Ah, I see! I'll push a fixing patch for this ASAP.
There was a problem hiding this comment.
Huh... well something strange is going on with this @bader. As far as I can tell, that code should be completely valid, and it is odd it only happens in that single configuration. I can't reproduce it in other configs either (nor does googling the important note give any hint).
That said, I've fixed it in this commit here: #3520
erichkeane
pushed a commit
to erichkeane/llvm
that referenced
this pull request
Apr 9, 2021
I'm not sure what causes this to not like this conversion, the error message seems incorrect and only on certain configs of the build, but we should fix the build anyway. This calls the StringRef pointer-size directly, rather than having the StringLiteral type do it.
bader
pushed a commit
that referenced
this pull request
Apr 9, 2021
I'm not sure what causes this to not like this conversion, the error message seems incorrect and only on certain configs of the build, but we should fix the build anyway. This calls the StringRef pointer-size directly, rather than having the StringLiteral type do it.
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Apr 14, 2021
* upstream/sycl: (39 commits) [CI] Switch to default clang-format version. (intel#3540) [Driver][NFC] Cleanup some option setting for SYCL offload (intel#3542) [GitHub Actions] Update main branch sync schedule [SYCL][NFC] Fix potential namespace conflicts with PSTL in tuple.hpp (intel#3541) [SYCL] Bump sycl library minor version (intel#3538) [SYCL][CUDA] Implemented cuda_piextUSMEnqueueMemAdvise (intel#3365) [SYCL][FPGA] Add mutual diagnostic of max_concurrency attribute in conjunction of disable_loop_pipelining attribute (intel#3512) [SYCL] [MATRIX] Enable joint_matrix_load, joint_matrix_store, and joint_matrix_mad for AMX (intel#3503) [ESIMD] Skip rewriting functions used through function pointers (intel#3527) [SYCL] Fix address space for spec constants buffer (intel#3521) [SYCL] Correct the tablegen for checking mutually exclusive stmt attrs (intel#3519) [SYCL][PI][L0][NFC] Refactor setting of LastCommandEvent (intel#3528) [SYCL] Fix group local memory sharing issue (intel#3489) [SYCL][NFC] Fix post-commit failure (intel#3532) [SYCL][Doc] Remove extension mechanism (intel#3526) [SYCL] Move sycl.hpp in install directory and adjust driver to match (intel#3523) [SYCL][ESIMD] Update ESIMD docs to address recent user comments: (intel#3516) [NFCI][SYCL] Correct -fdeclare-spirv-builtins to use marshalling (intel#3515) [SYCL] Rework MarkDevice and children (intel#3475) [SYCL] Fix StringLiteral Ctor issue from intel#3504. (intel#3520) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified elsewhere, these are a few cases of 'simple' types that are
intended to be copied being passed around as const references. This
patch just replaces them.
Also, StringRefs for can be just llvm::StringLiteral for literals, since
that does constexpr construction.