[SYCL][CUDA] Update code when llvm.used is removed #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanBeltonS
requested review from
AlexeySachkov,
kbobrovs and
mlychkov
as code owners
AidanBeltonS
changed the title
|
@AidanBeltonS Could you please add a test for this fix? |
Yes, ill work on adding one to test the desired behaviour. |
AidanBeltonS
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
mlychkov
reviewed
Aug 31, 2021
bader
reviewed
Aug 31, 2021
mlychkov
reviewed
Sep 1, 2021
Co-authored-by: Mikhail Lychkov <51128024+mlychkov@users.noreply.github.com>
bader
approved these changes
Sep 1, 2021
mlychkov
approved these changes
Sep 1, 2021
AlexeySachkov
added a commit
to AlexeySachkov/llvm
that referenced
this pull request
Nov 10, 2021
If declaration is treated as entry point, then we will create a device image which claims that it contains particular kernel, while it actually doesn't - that leads to errors at runtime. Kernel declarations can appear in input modules as a side effect of intel#4409. The PR postponed removal of `@llvm.used` variable from input modules, which results in kernel declarations left in modules after split between SYCL and ESIMD kernels.
dm-vodopyanov
pushed a commit
that referenced
this pull request
Nov 12, 2021
If declaration is treated as entry point, then we will create a device image which claims that it contains particular kernel, while it actually doesn't - that leads to errors at runtime. Kernel declarations can appear in input modules as a side effect of #4409. The PR postponed removal of `@llvm.used` variable from input modules, which results in kernel declarations left in modules after split between SYCL and ESIMD kernels.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
sycl-post-linkllvm.used should be removed. Otherwise it can cause a crash further on.This patch checks to see if llvm.used is removed and if it is prevents the old code from being reused in the table.
This fixes #4294.
See issue for more details on problem.