[sycl-post-link] Do not treat declarations as entry points #4927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If declaration is treated as entry point, then we will create a device image which claims that it contains particular kernel, while it actually doesn't - that leads to errors at runtime. Kernel declarations can appear in input modules as a side effect of intel#4409. The PR postponed removal of `@llvm.used` variable from input modules, which results in kernel declarations left in modules after split between SYCL and ESIMD kernels.
kbobrovs
approved these changes
Nov 12, 2021
AlexeySachkov
deleted the
private/asachkov/ignore-declarations-in-device-code-split
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If declaration is treated as entry point, then we will create a
device image which claims that it contains particular kernel,
while it actually doesn't - that leads to errors at runtime.
Kernel declarations can appear in input modules as a side
effect of #4409. The PR postponed removal of
@llvm.usedvariable from input modules, which resultsin kernel declarations left in modules after split between
SYCL and ESIMD kernels.