[SYCL][HIP] Fix reported device name #5508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AMD GPUs it seems that `hipDeviceGetName` returns an empty string, so
when this is the case simply return the architecture instead, as this
what AMD OpenCL devices return for the name.
Before this patch:
```
Devices : 1
Device [#0]:
Type : gpu
Version : 0.0
Name :
Vendor : AMD Corporation
Driver : HIP 40421.43
```
After this patch:
```
Devices : 1
Device [#0]:
Type : gpu
Version : 0.0
Name : gfx908:sramecc+:xnack-
Vendor : AMD Corporation
Driver : HIP 40421.43
```
Contributor
Author
|
ping @smaslov-intel @intel/llvm-reviewers-runtime |
smaslov-intel
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AMD GPUs it seems that
hipDeviceGetNamereturns an empty string, sowhen this is the case simply return the architecture instead, as this
what AMD OpenCL devices return for the name.
Before this patch:
After this patch: