Skip to content

[SYCL][HIP] Fix reported device name #5508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022
Merged

[SYCL][HIP] Fix reported device name #5508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions sycl/plugins/hip/pi_hip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1450,6 +1450,17 @@ pi_result hip_piDeviceGetInfo(pi_device device, pi_device_info param_name,
cl::sycl::detail::pi::assertion(
hipDeviceGetName(name, MAX_DEVICE_NAME_LENGTH, device->get()) ==
hipSuccess);

// On AMD GPUs hipDeviceGetName returns an empty string, so return the arch
// name instead, this is also what AMD OpenCL devices return.
if (strlen(name) == 0) {
hipDeviceProp_t props;
cl::sycl::detail::pi::assertion(
hipGetDeviceProperties(&props, device->get()) == hipSuccess);

return getInfoArray(strlen(props.gcnArchName) + 1, param_value_size,
param_value, param_value_size_ret, props.gcnArchName);
}
return getInfoArray(strlen(name) + 1, param_value_size, param_value,
param_value_size_ret, name);
}
Expand Down