[NFC][SYCL] Remove FIXME comment #6351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kernel_arg_accessor_ptr metadata is conveying to the BE the requirement that argument be implemented using a surface. This is different from information conveyed by metadatas kernel_arg_exclusive_ptr and kernel_arg_runtime_aligned. Therefore, we cannot replace kernel_arg_accessor_ptr. Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
smanna12
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metadata kernel_arg_accessor_ptr is conveying to the BE the
requirement that the corresponding argument be
implemented using a surface.
This is different from information conveyed by metadata
kernel_arg_exclusive_ptr and kernel_arg_runtime_aligned.
Therefore, we cannot replace kernel_arg_accessor_ptr.
Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com