[SYCL] match existing device_impl from context, rather than creating a new one. #6423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is not strictly correct. Presently this SYCL implementation assumes there is a 1:1 relationship between devicesPI and devic_impl. By creating a new one, there will now be two device_impls (one already in the context) for the same devicePI. In this PR we are simply finding the matching device_impl in the Context and using that rather than creating a nnew one. Signed-off-by: Chris Perkins <chris.perkins@intel.com>
Contributor
Author
|
ping to reviewers. This is on the MFL and will need expediting. |
againull
reviewed
Jul 12, 2022
Contributor
sergey-semenov
left a comment
sergey-semenov
left a comment
There was a problem hiding this comment.
Could you please add a test for this change?
Also, since the interop constructor now actually makes a check and throws an exception, we'll need to align it with #5882 in whichever PR gets merged last.
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
againull
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the queue_impl(PI) constructor is creating a new device_impl, but that is not strictly correct. Presently this SYCL implementation assumes there is a 1:1 relationship between devicePI and device_impl. By creating a new one, there will now be two device_impls (one already in the context) for the same devicePI. In this PR we are simply finding the matching device_impl in the Context and using that rather than creating a new one, preserving the 1:1 relationship.
Signed-off-by: Chris Perkins chris.perkins@intel.com