-
Notifications
You must be signed in to change notification settings - Fork 809
[SYCL] Finally fix iostream_proxy.hpp #6517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Many thanks to @AaronBallman for helping with this! |
AaronBallman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, these changes LGTM.
For reference, when _MT and _DLL are both defined, the user has passed /MD or /MDd and is dynamically linking in the runtimes. Because std::cout etc are data, they need to be marked dllimport in that case or else the linker cannot find them.
This should be in PR description I think. |
|
I believe are known and there was/were issue(s) submitted for that. @intel/llvm-gatekeepers , ready to merge? |
|
Failing test is being disabled at intel/llvm-test-suite#1127. |
When _MT and _DLL are both defined, the user has passed /MD or /MDd and is dynamically linking in the runtimes. Because std::cout etc are data, they need to be marked dllimport in that case or else the linker cannot find them.
When _MT and _DLL are both defined, the user has passed /MD or /MDd and
is dynamically linking in the runtimes. Because std::cout etc are data,
they need to be marked dllimport in that case or else the linker cannot
find them.