[SYCL][CUDA] Add concurrent memory check to mem_advice #6567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
previously approved these changes
Aug 11, 2022
steffenlarsen
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to CUDA's mem advice to make sure the memory passed is managed memory. This change makes
mem_adviseline up withprefetchin terms of checking that both the device supports concurrent managed memory and that the memory passed to the function is managed.This is to prevent
cuMemAdvisefrom failing on the SYCLmem_adviseCTS tests.