Skip to content

[SYCL][CUDA] Add concurrent memory check to mem_advice #6567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvchupin merged 3 commits into from
Aug 11, 2022
Merged

[SYCL][CUDA] Add concurrent memory check to mem_advice #6567

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86027b2
Add concurrent memory check to mem advise
Aug 11, 2022
993dfc8
Update sycl/plugins/cuda/pi_cuda.cpp
AidanBeltonS Aug 11, 2022
2236f7a
clang-format
Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions sycl/plugins/cuda/pi_cuda.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5110,6 +5110,16 @@ pi_result cuda_piextUSMEnqueueMemAdvise(pi_queue queue, const void *ptr,
// CU_DEVICE_ATTRIBUTE_PAGEABLE_MEMORY_ACCESS property.
}

unsigned int is_managed;
PI_CHECK_ERROR(cuPointerGetAttribute(
&is_managed, CU_POINTER_ATTRIBUTE_IS_MANAGED, (CUdeviceptr)ptr));
if (!is_managed) {
setErrorMessage(
"Memory advice ignored as memory advices only works with USM",
PI_SUCCESS);
return PI_ERROR_PLUGIN_SPECIFIC_ERROR;
}

pi_result result = PI_SUCCESS;
std::unique_ptr<_pi_event> event_ptr{nullptr};

Expand Down