Skip to content

[NFC] Fix fail on Windows #7064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pvchupin merged 1 commit into from
Oct 14, 2022
Merged

[NFC] Fix fail on Windows #7064

pvchupin merged 1 commit into from
Oct 14, 2022

Conversation

@elizabethandrews
Copy link
Contributor

@elizabethandrews elizabethandrews commented Oct 14, 2022

size_t differences cause different IR in Windows and Linux.

Signed-off-by: Elizabeth Andrews elizabeth.andrews@intel.com

@elizabethandrews
Fix fail on Windows
0f35bd6 
Signed-off-by: Elizabeth Andrews <elizabeth.andrews@intel.com>
@elizabethandrews elizabethandrews requested a review from a team as a code owner October 14, 2022 17:21
@elizabethandrews
Copy link
Contributor Author

elizabethandrews commented Oct 14, 2022

I believe this fixed the post-commit fail after - #7015, but I couldn't get a Windows compiler to build and so I have not tested this.

@elizabethandrews elizabethandrews mentioned this pull request Oct 14, 2022
Merged
premanandrao
premanandrao approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me. What is the type on Windows - 'unsigned int' ?

smanna12
smanna12 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elizabethandrews
Copy link
Contributor Author

elizabethandrews commented Oct 14, 2022

Looks okay to me. What is the type on Windows - 'unsigned int' ?

It was 'unsigned long long'

@pvchupin
Copy link
Contributor

pvchupin commented Oct 14, 2022

ESIMD issues are unrelated and expected to be fixed by #6661

@pvchupin pvchupin merged commit 4954977 into intel:sycl Oct 14, 2022
@pvchupin
Copy link
Contributor

pvchupin commented Oct 14, 2022 •
edited
Loading

@elizabethandrews, looks like one test still fails: https://github.com/intel/llvm/actions/runs/3252241458/jobs/5338227023

Failed Tests (1):
  Clang :: SemaSYCL/array-kernel-param.cpp

@elizabethandrews
Copy link
Contributor Author

elizabethandrews commented Oct 17, 2022

@elizabethandrews, looks like one test still fails: https://github.com/intel/llvm/actions/runs/3252241458/jobs/5338227023

Failed Tests (1):
  Clang :: SemaSYCL/array-kernel-param.cpp

I fixed it here - #7082. I was able to test a Windows build this time and this test passes with this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@premanandrao premanandrao premanandrao approved these changes

@pvchupin pvchupin Awaiting requested review from pvchupin

+1 more reviewer

@smanna12 smanna12 smanna12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elizabethandrews @pvchupin @premanandrao @smanna12