Support llvm headers in ${LLVM_LIBRARY_DIRS}/clang/${LLVM_VERSION_MAJOR}/ #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenju-he
reviewed
Apr 17, 2023
cl_headers/CMakeLists.txt
Outdated
| set(OPENCL_HEADERS_DIR | ||
| "${LLVM_LIBRARY_DIRS}/clang/${LLVM_VERSION_MAJOR}/include/") | ||
| else() | ||
| message(FATAL_ERROR "[OPENCL-CLANG] Couldn't find LLVM include directory.") |
There was a problem hiding this comment.
Suggested change
| message(FATAL_ERROR "[OPENCL-CLANG] Couldn't find LLVM include directory.") | |
| message(FATAL_ERROR "[OPENCL-CLANG] Couldn't find prebuilt LLVM include directory.") |
…OR}/
Fedora places llvm include files into that directory instead of assumed
${LLVM_LIBRARY_DIRS}/clang/${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}/include/
Try both, fail horribly when none of them exist
frantisekz
force-pushed
the
support_llvm_major_include
branch
from
bd7f2ab to
1568bb9
Compare
Likely related to llvm/llvm-project@e1b88c8a09be |
pld-gitsync
pushed a commit
to pld-linux/opencl-clang
that referenced
this pull request
May 20, 2023
multiple upstream fixes for build failures/missing soname from: intel/opencl-clang#416 intel/opencl-clang#419 intel/opencl-clang#437 intel/opencl-clang#439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora places llvm include files into that directory instead of assumed ${LLVM_LIBRARY_DIRS}/clang/${LLVM_VERSION_MAJOR}.${LLVM_VERSION_MINOR}.${LLVM_VERSION_PATCH}/include/
Try both, fail horribly when none of them exist