Revert to use add_llvm_library and revert linking LLVM libraries #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2023
haonanya
approved these changes
May 18, 2023
pld-gitsync
pushed a commit
to pld-linux/opencl-clang
that referenced
this pull request
May 20, 2023
multiple upstream fixes for build failures/missing soname from: intel/opencl-clang#416 intel/opencl-clang#419 intel/opencl-clang#437 intel/opencl-clang#439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add cmake option EXCLUDE_LIBS_FROM_ALL to remove a specific llvm library from llvm 'all'.
This PR partially reverts 743bd15.
This PR addresses #401, #417, #418, #422, and brings back SONAME.