[RFC/DRAFT]: InitializeNativeTarget() instead of InitializeAllTargets() #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes/works around: intel#417 The other way around would be to link against all the Targets that LLVM Supports.
|
ping @haonanya |
|
Please, double check this before merging, I am really not sure this is the correct way to handle the issue. It for sure fixed my use case, it may (or may not) break others, I didn't dig into all the possible implications of this change. |
|
Thanks for the reminder, I will check if the patch work with other build asap. |
wenju-he
reviewed
May 16, 2023
| @@ -371,6 +371,7 @@ install(FILES opencl_clang.h | |||
| DESTINATION include/cclang | |||
| COMPONENT ${TARGET_NAME}) | |||
|
|
|||
| add_custom_target(deploy DEPENDS install-${TARGET_NAME}) | |||
There was a problem hiding this comment.
I'll double check if the change in this file is needed
|
Resolved by #439 , this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/works around: #417
The other way around would be to link against all the Targets that LLVM Supports.