Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipcl_v2.0.0 is incompatible with gcc/g++-8 #40

Closed
fangxiaoran opened this issue Nov 26, 2022 · 3 comments
Closed

ipcl_v2.0.0 is incompatible with gcc/g++-8 #40

fangxiaoran opened this issue Nov 26, 2022 · 3 comments

Comments

@fangxiaoran
Copy link

Hi @skmono, in this commit aac0eb4#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20a, -Wno-error=deprecated-copy was added as CMAKE_C_FLAGS and CMAKE_CXX_FLAGS.

However, this warning was announced since gcc-9. It's not supported by gcc/g++-8, which is used to build ipcl_python currently within Docker container. This incompatibility leads to a find_package failure as below. Can we just remove it from cmake flags?

image
@fangxiaoran
Copy link
Author

I've tried to use devtoolset-9 to build ipcl_python, rather than devtoolset-8, and it worked. So I think another solution is keeping this flag and updating dependencies in README.

@skmono
Copy link
Contributor

skmono commented Nov 28, 2022

@fangxiaoran Good find. I'll update the compile flags per gcc version.

skmono pushed a commit that referenced this issue Nov 28, 2022
Add GNU version check for "deprecated-copy" flag - address #40
69d888d
@skmono skmono mentioned this issue Nov 28, 2022
Merged
skmono pushed a commit that referenced this issue Nov 28, 2022
Hotfix: Add gcc version check for "-Wno-deprecated-copy" flag (gnu>=9…
c15487c 
….1.0) (#42)

Fix issue #40
@skmono
Copy link
Contributor

skmono commented Nov 28, 2022

Fixed with PR #42

@skmono skmono closed this as completed Nov 28, 2022
skmono pushed a commit that referenced this issue Nov 30, 2022
@justalittlenoob
Refactor pub priv key with smark pointers (#38)
c5bf45b 
* Major updates
  - pubkey, privkey: Refactor pubkey & privkey with shared_ptr and remove pubkey from privkey
  - Ciphertext: Support shared_ptr public key
  - keypair: refactor KeyPair structure
  - Add serialization support for BigNumber and PublicKey (PrivateKey and CipherText WIP)
  - Add GNU version check for "deprecated-copy" flag - address #40

* Minor Updates
  - unittest, benchmark, examples: Updated with smart ptr version pk, sk and keypair
  - Updated example/README markdown to reflect changes to ipcl::KeyPair and its members.
  - Minor typo fixes

Signed-off-by: Zhao Pengfei <pengfei.zhao@intel.com>
Co-authored-by: skmono <sejun.kim@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skmono @fangxiaoran