Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pub priv key with smark pointers #38

Merged
merged 12 commits into from
Nov 30, 2022
Merged

Refactor pub priv key with smark pointers #38

merged 12 commits into from
Nov 30, 2022

Conversation

justalittlenoob
Copy link
Contributor

No description provided.

@justalittlenoob justalittlenoob temporarily deployed to intel_workflow November 21, 2022 10:59 Inactive
@justalittlenoob justalittlenoob temporarily deployed to intel_workflow November 22, 2022 12:58 Inactive
@justalittlenoob justalittlenoob temporarily deployed to intel_workflow November 22, 2022 13:31 Inactive
@justalittlenoob
pk, sk, ct: Refactor pk & sk with shared_ptr.
98987dc 
Signed-off-by: Zhao Pengfei <pengfei.zhao@intel.com>
@justalittlenoob
keypair: refactor KeyPair structure
a994314 
Signed-off-by: Zhao Pengfei <pengfei.zhao@intel.com>
@justalittlenoob
unittest, benchmark: Updated with smart ptr version pk, sk and keypair
cc3c58f 
Signed-off-by: Zhao Pengfei <pengfei.zhao@intel.com>
@justalittlenoob justalittlenoob force-pushed the zpf/refactor-pub-priv-with-smarkpointer branch from ae12eed to cc3c58f Compare November 23, 2022 12:21
@justalittlenoob
example: Updated with smart ptr version pk, sk and keypair
dc6c3a9 
Signed-off-by: Zhao Pengfei <pengfei.zhao@intel.com>
@justalittlenoob justalittlenoob marked this pull request as ready for review November 24, 2022 04:40
@justalittlenoob justalittlenoob requested a review from a team as a code owner November 24, 2022 04:40
@justalittlenoob
sk: Change pk parameter type in ctor.
66de741 
ct: Change pk parameter type in ctor and m_pk type.
pk, unittest, benchmark: Updated with new sk & ct structure.

Signed-off-by: Zhao Pengfei <pengfei.zhao@intel.com>
@skmono
Copy link
Contributor

skmono commented Nov 24, 2022

@justalittlenoob Let me try the serialization methods on this recent update

Minor updates:
25f62ba 
- Reverted keyPair names to pub_key, priv_key (same as previous implementation) to avoid confusion - can change after v2.1 with deprecation warning
- Fully functional BigNumber and PublicKey serialization
- PrivateKey and CipherText serialization WIP
@skmono
Copy link
Contributor

skmono commented Nov 28, 2022

@justalittlenoob Made a few changes - reverted keypair member names. If we want to update the names, let's do it with a buffer version where we can display some warning messages that the names will be changed.
Overall, it works perfectly fine. Will need to modify the Python bindings due to some changes we made. I'll verify it with IPCL-Python then let's merge it.

@justalittlenoob
Copy link
Contributor Author

@justalittlenoob Made a few changes - reverted keypair member names. If we want to update the names, let's do it with a buffer version where we can display some warning messages that the names will be changed. Overall, it works perfectly fine. Will need to modify the Python bindings due to some changes we made. I'll verify it with IPCL-Python then let's merge it.

Sure. I agree. Very good advice:)

@skmono skmono temporarily deployed to intel_workflow November 29, 2022 06:50 Inactive
@skmono
Copy link
Contributor

skmono commented Nov 29, 2022

@justalittlenoob Added a few more updates - let me know what you think. Let's complete the PR after the CI/CD system is back online

@justalittlenoob
Copy link
Contributor Author

@justalittlenoob Added a few more updates - let me know what you think. Let's complete the PR after the CI/CD system is back online

It looks good to me.

@skmono skmono temporarily deployed to intel_workflow November 30, 2022 01:06 Inactive
@skmono skmono merged commit c5bf45b into ipcl_v2.0.0 Nov 30, 2022
@skmono skmono deleted the zpf/refactor-pub-priv-with-smarkpointer branch November 30, 2022 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skmono skmono skmono approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justalittlenoob @skmono