Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit width to Const generated SystemVerilog #94

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

mkorbel1
Copy link
Contributor

Description & Motivation

Fix #89 which caused Consts in swizzles to break in generated SystemVerilog.

Related Issue(s)

#89

Testing

Added a new test which fails without this fix.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

No, but it does change the way SystemVerilog gets printed for constants.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No

@mkorbel1 mkorbel1 merged commit 2d422b0 into intel:main Mar 28, 2022
@mkorbel1 mkorbel1 deleted the constfix branch March 28, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constants in generated SystemVerilog are unsized
1 participant