Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogue Manager #9

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

Dialogue Manager #9

wants to merge 61 commits into from

Conversation

RMichaelSwan
Copy link

@RMichaelSwan RMichaelSwan commented Jan 13, 2020

Restructuring of code to be more easily understood and added conversation integration with Amazon Lex.

A diagram to better understand all the restructuring changes can be found here:
https://www.notion.so/Interface-0ea622e7cd2f41d290763495db1f0a2b

<version>0.1.2</version>
<description >

Interface to use CoRDial with Ivona Text-To-Speech
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for the skeleton tracking or sound detection?


class BehaviorManager():

def __init__(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this handle having multiple robots, or is there one behavior manager per robot?

start_time = rospy.Time.now()
for index, behav in enumerate(ordered_timing_word_behaviors[:-1]):
if behav["type"] != "word":
while rospy.Time.now()-start_time < rospy.Duration.from_sec(behav["start"]):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait does this block the sending of facial expressions in handle_behavior?

INTERACTION_MESSAGE = ''
INTERACTION_CONTINUE = True

class LongBehaviorServer():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have to ask about long behaviors--my intuition is that it is things like tracking or logging or something, is that right?


</description>
<author>Elaine Short</author>
<maintainer email="prmehta24@gmail.com">Micol Spitale</maintainer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might want to change the email

from audio_common_msgs.msg import AudioData
from cordial_manager.msg import *

PROMPT_MESSAGE = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe not necessarily for this one, but we might want globals on rosparam server so other scripts can see them, or have them as part of the dialogue server

@@ -0,0 +1,14 @@
#!/usr/bin/env python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I think it would be nice to separate out the QT-specific scripts from the general purpose ones

killall http-server

source /opt/ros/kinetic/setup.bash
source /home/qtrobot/catkin_ws/devel/setup.bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be able to be made more general with some kind of environment variables

global SYNTHESIZE_DONE
print("The TTS message received is:" + data)
#outdir = os.path.dirname(os.path.abspath("home
outdir = "/home/qtrobot/catkin_ws/src/cordial-public/cordial_dialogue/scripts/data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might want to use some env variable to store the temporary files

@RMichaelSwan RMichaelSwan force-pushed the feature/dialogue_manger branch from f46a46f to a0b4563 Compare February 21, 2020 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants