Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sklearn build error due to old dependency version installed with newer scipy #568

Merged

Conversation

imatiach-msft
Copy link
Collaborator

Recently started seeing gated build failures with the error:

2023-07-10T03:26:24.2325334Z         if one_alpha:
2023-07-10T03:26:24.2325569Z             A.flat[:: n_features + 1] += alpha[0]
2023-07-10T03:26:24.2325960Z >           return linalg.solve(A, Xy, sym_pos=True, overwrite_a=True).T
2023-07-10T03:26:24.2326366Z E           TypeError: solve() got an unexpected keyword argument 'sym_pos'

link to build:
https://pipelines.actions.githubusercontent.com/serviceHosts/c1806717-186f-43d1-b5bb-864035754060/_apis/pipelines/1/runs/1609/signedlogcontent/2?urlExpires=2023-07-10T15%3A33%3A11.6111338Z&urlSigningMethod=HMACV1&urlSignature=5aCYsNh0b1aoNRoesrWhta7mxH8IrH5Crdw%2BgiVPGtI%3D

This issue seems to be due to newer scikit learn initially being installed with latest scipy and then due to the restrictions in responsibleai pypu package an older version of scikit-learn being subsequently installed.
This PR temporarily fixes the issue by re-installing latest version of scikit-learn until the bound is removed.

@imatiach-msft imatiach-msft force-pushed the ilmat/fix-sklearn-ci-err branch from 7ac1fab to f69caeb Compare July 10, 2023 18:33
@imatiach-msft imatiach-msft force-pushed the ilmat/fix-sklearn-ci-err branch from f69caeb to 7a2c4f9 Compare July 10, 2023 20:05
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (cb3ce2e) 87.70% compared to head (7a2c4f9) 87.70%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   87.70%   87.70%           
=======================================
  Files          62       62           
  Lines        4075     4075           
=======================================
  Hits         3574     3574           
  Misses        501      501           
Flag Coverage Δ
unittests 87.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imatiach-msft imatiach-msft merged commit e4e75f9 into interpretml:main Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants