release scikit-learn upper bound in responsibleai package #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imatiach-msft
requested review from
gaugup,
xuke444,
kicha0,
RubyZ10,
vinuthakaranth,
tongyu-microsoft and
hawestra
as code owners
gaugup
approved these changes
Jul 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #2173 +/- ##
===========================================
+ Coverage 78.09% 92.22% +14.13%
===========================================
Files 26 103 +77
Lines 2159 5143 +2984
===========================================
+ Hits 1686 4743 +3057
+ Misses 473 400 -73
Flags with carried forward coverage won't be shown. Click here to find out more. |
imatiach-msft
force-pushed
the
ilmat/fix-sklearn-bound
branch
from
26cb410 to
929d450
Compare
imatiach-msft
force-pushed
the
ilmat/fix-sklearn-bound
branch
from
929d450 to
16ace94
Compare
imatiach-msft
force-pushed
the
ilmat/fix-sklearn-bound
branch
from
16ace94 to
9627c1f
Compare
gaugup
approved these changes
Aug 2, 2023
vinuthakaranth
approved these changes
Aug 2, 2023
libs/e2e/src/lib/describer/modelAssessment/datasets/DiabetesDecisionMaking.ts
Show resolved
Hide resolved
kicha0
pushed a commit
that referenced
this pull request
Aug 2, 2023
Signed-off-by: root <kicha@microsoft.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It seems that the scikit-learn upper bound is causing issues in other libraries/builds where responsibleai is installed.
For example, see the PR fix for: interpretml/interpret-community#568
Removing the upper bound here and just removing the 1.1 scikit-learn version from compatible dependencies list in the setup.py file.
Please also see the similar and related PR from a year ago:
#1464
I think it might be a bit too early to go for just >1.1.0 yet.
Checklist