fix: wrong icm fallback is used when configured icm throws errors on SSR #1519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…allback on production mode, pwa error should only contain properties of defined HttpError interface
shauke
force-pushed
the
fix/wrong-icm-fallback-on-error
branch
from
c93cd9e
to
d556e6c
Compare
shauke
approved these changes
Oct 16, 2023
shauke
added a commit
that referenced
this pull request
Nov 17, 2023
…ICM throws errors on SSR (#1519)" * reverted: icmBaseURL no longer uses environment.ts fallback in production mode * reverted: make usage of default/fallback configuration in environment.ts configurable for getting state properties * refactored: errors should only contain properties of defined HttpError interface - this is now handled at the error interceptor * kept: do not log an error that can't be stringified, it floods the log with irrelevant information BREAKING CHANGES: No longer a breaking change regarding "No longer falls back to `environment.ts` configured `icmBaseURL` in production mode."
shauke
added a commit
that referenced
this pull request
Nov 20, 2023
…SR" (#1533) fix: revert irrelevant changes of "wrong ICM is used when configured ICM throws errors on SSR (#1519)" * reverted: icmBaseURL no longer uses environment.ts fallback in production mode * reverted: make usage of default/fallback configuration in environment.ts configurable for getting state properties * refactored: errors should only contain properties of defined HttpError interface - this is now handled at the error interceptor * kept: do not log an error that can't be stringified, it floods the log with irrelevant information BREAKING CHANGES: No longer a breaking change regarding "No longer falls back to `environment.ts` configured `icmBaseURL` in production mode."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[ x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no API changes)
[ ] Build-related changes
[ ] CI-related changes
[ ] Documentation content changes
[ ] Application / infrastructure changes
[ ] Other:
What Is the Current Behavior?
On SSR the PWA renders a given page. It sets a transferState, which will be used on browser side afterwards. When an error for the given ICM occurs on SSR (e.g. wrong certificate), it is possible, that wrong error properties are set in state. This can lead to the problem, that
JSON.stringify(state)throws an error due to the incorrect state. The outcome is, that no transferState is set on SSR. The browser side cannot retrieve the configured ICM anymore and incorrectly use the fallback (configured in environment..ts).Issue Number: Closes #
What Is the New Behavior?
error.reducer.tsare reduced to the defined set of the predefinedHttpErrorinterfaceicmBaseUrlin production modeDoes this PR Introduce a Breaking Change?
[ x ] Yes
[ ] No
No fallback for icmBaseUrl in production mode. The given option
disableOptionto apply configurations can be removed in order to retain the old behavior.Other Information
AB#90030