fix: improved NGINX route rewrite handling for '/home' and '/loading' #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* addresses issues with trailing slashes for MULTI_CHANNEL configurations without 'baseHref' (introduced with #1553) * fix "the rewritten URI has a zero length" error in nginx multi channel handling * prevents canonical links with doubled "/"(slash) between the domain name and the rest of the path
shauke
force-pushed
the
bugfix/nginx_empty_redirect
branch
from
614862c to
a804da4
Compare
shauke
changed the title
dhhyi
previously approved these changes
Mar 5, 2024
shauke
force-pushed
the
bugfix/nginx_empty_redirect
branch
from
cc4d8b3 to
a804da4
Compare
shauke
added a commit
that referenced
this pull request
Mar 7, 2024
…#1566) * addresses issues with trailing slashes for MULTI_CHANNEL configurations without 'baseHref' (introduced with #1553) * fix "the rewritten URI has a zero length" error in nginx multi channel handling * prevents canonical links with doubled "/"(slash) between the domain name and the rest of the path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Bugfix
What Is the Current Behavior?
The fix for " trailing '/' in path results to a wrong multi channel configuration (#1553)" results in NGINX re-writting errors ("the rewritten URI has a zero length") for
MULTI_CHANNELconfigurations that use the defaultbaseHrefof/when accessing the root route with https://intershoppwa.azurewebsites.net instead of https://intershoppwa.azurewebsites.net/home.In addition the canonical link element is not correctly generated at the root. The double
//between the domain name and thehomeroute can be interpreted by search enginesas a duplicate, and thus impact the SEO ranking of the website.What Is the New Behavior?
The NGINX route rewrite handling for '/home' and '/loading' was improved to work with
MULTI_CHANNELconfigurations with and without the defaultbaseHrefof/.The NGINX rewriting removes now all trailing slashes.
The NGINX rewriting prevents canonical links with doubled
//between the domain name and the rest of the path.Does this PR Introduce a Breaking Change?
[x] No
Other Information
AB#92520