memoize selectors for categories #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/categories_selector_memoization
branch
3 times, most recently
from
2f18352
to
855a1e0
Compare
dhhyi
force-pushed
the
refactor/categories_selector_memoization
branch
from
855a1e0
to
064e050
Compare
dhhyi
force-pushed
the
refactor/categories_selector_memoization
branch
4 times, most recently
from
dd4c7aa
to
8272ea9
Compare
dhhyi
force-pushed
the
refactor/breadcrumb-component
branch
from
11b0871
to
bc39bd6
Compare
dhhyi
force-pushed
the
refactor/categories_selector_memoization
branch
from
8272ea9
to
a355f87
Compare
dhhyi
force-pushed
the
refactor/breadcrumb-component
branch
from
bc39bd6
to
cb9ae13
Compare
dhhyi
force-pushed
the
refactor/categories_selector_memoization
branch
from
a355f87
to
c78209e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Feature
[x] Other: Performance Improvements
What Is the Current Behavior?
Category selectors are not correctly memoized and can trigger unnecessary view updates.
Issue Number: Closes #245
What Is the New Behavior?
Memoization exists
Does this PR Introduce a Breaking Change?
[ ] Yes
[x] No
Other Information