refactor: breadcrumb component #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhhyi
force-pushed
the
refactor/breadcrumb-component
branch
6 times, most recently
from
11b0871
to
bc39bd6
Compare
shauke
previously approved these changes
Jun 29, 2020
BREAKING CHANGE: setting the breadcrumb trail can now only be done consistently by using route data or by dispatching the appropriate action
dhhyi
force-pushed
the
refactor/breadcrumb-component
branch
from
bc39bd6
to
cb9ae13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
[x] Refactoring (no functional changes, no API changes)
What Is the New Behavior?
Bread Crumb Trail is consistently set via store through either routing parameters of effects.
Does this PR Introduce a Breaking Change?
[x] Yes
[ ] No
Other Information
relates to #284, #245